Refactor playwright tests, change button text for better usability and validate mimetype in API layer

2025-11-22 10:51:36 +01:00 · 2024-10-25 19:23:38 +02:00
parent 4e98df5790
commit f79cbffa5a
38 changed files with 1396 additions and 1167 deletions
--- a/web-app/src/routes/(anonymous)/login/+page.svelte
+++ b/web-app/src/routes/(anonymous)/login/+page.svelte
@@ -25,5 +25,5 @@
    <input type="password" name="password" required />
  </label>

-  <button type="submit">Submit</button>
+  <button type="submit">Login</button>
 </form>
--- a/web-app/src/routes/(anonymous)/register/+page.svelte
+++ b/web-app/src/routes/(anonymous)/register/+page.svelte
@@ -52,7 +52,7 @@
        <input type="password" name="password" minlength="12" maxlength="128" required />
      </label>

-      <button type="submit">Submit</button>
+      <button type="submit">Register</button>
    </form>

    <details>
--- a/web-app/src/routes/(authenticated)/+page.svelte
+++ b/web-app/src/routes/(authenticated)/+page.svelte
@@ -39,7 +39,7 @@
        <input type="text" name="title" maxlength="50" pattern="\S(.*\S)?" required />
      </label>

-      <button type="submit">Submit</button>
+      <button type="submit">Create website</button>
    </form>
  </Modal>
 </section>
@@ -72,7 +72,7 @@
            >
          </select>
        </label>
-        <button type="submit">Submit</button>
+        <button type="submit">Apply</button>
      </form>
    </details>

@@ -105,7 +105,7 @@
              >
                <input type="hidden" name="id" value={id} />
                <label>
-                  Title
+                  Title:
                  <input
                    type="text"
                    name="title"
@@ -119,7 +119,7 @@
                <button
                  type="submit"
                  disabled={data.user.id !== user_id && collab[0].permission_level !== 30}
-                  >Submit</button
+                  >Update website</button
                >
              </form>
            </Modal>
--- a/web-app/src/routes/(authenticated)/account/+page.svelte
+++ b/web-app/src/routes/(authenticated)/account/+page.svelte
@@ -108,9 +108,4 @@
    flex-direction: column;
    gap: var(--space-3xs);
  }
-
-  meter {
-    inline-size: min(512px, 100%);
-    block-size: 2rem;
-  }
 </style>
--- a/web-app/src/routes/(authenticated)/manage/+page.svelte
+++ b/web-app/src/routes/(authenticated)/manage/+page.svelte
@@ -68,7 +68,7 @@
                      value={max_number_websites}
                    />
                  </label>
-                  <button type="submit">Submit</button>
+                  <button type="submit">Update website limit</button>
                </form>

                {#if website.length > 0}
@@ -92,7 +92,7 @@
                              value={max_storage_size}
                            />
                          </label>
-                          <button type="submit">Submit</button>
+                          <button type="submit">Update storage limit</button>
                        </form>
                      </div>
                    </details>
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/+page.server.ts
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/+page.server.ts
@@ -43,7 +43,6 @@ export const actions: Actions = {
    };

    if (faviconFile) {
-      headers["X-Mimetype"] = faviconFile.type;
      headers["X-Original-Filename"] = faviconFile.name;
    }

@@ -84,7 +83,6 @@ export const actions: Actions = {
    };

    if (logoImage) {
-      headers["X-Mimetype"] = logoImage.type;
      headers["X-Original-Filename"] = logoImage.name;
    }

@@ -152,7 +150,6 @@ export const actions: Actions = {
        "Content-Type": "application/octet-stream",
        Accept: "application/vnd.pgrst.object+json",
        "X-Website-Id": params.websiteId,
-        "X-Mimetype": file.type,
        "X-Original-Filename": file.name
      },
      body: await file.arrayBuffer(),
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/+page.svelte
@@ -95,7 +95,7 @@
        {/if}
      </div>

-      <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+      <button type="submit" disabled={data.permissionLevel === 10}>Update global</button>
    </form>
  </section>

@@ -142,7 +142,7 @@
        {/if}
      </div>

-      <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+      <button type="submit" disabled={data.permissionLevel === 10}>Update header</button>
    </form>
  </section>

@@ -165,7 +165,7 @@
        content={data.home.main_content}
      />

-      <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+      <button type="submit" disabled={data.permissionLevel === 10}>Update home</button>
    </form>
  </section>

@@ -182,7 +182,7 @@
        >
      </label>

-      <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+      <button type="submit" disabled={data.permissionLevel === 10}>Update footer</button>
    </form>
  </section>
 </WebsiteEditor>
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/articles/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/articles/+page.svelte
@@ -40,7 +40,7 @@
          <input type="text" name="title" pattern="\S(.*\S)?" maxlength="100" required />
        </label>

-        <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+        <button type="submit" disabled={data.permissionLevel === 10}>Create article</button>
      </form>
    </Modal>
  </section>
@@ -74,7 +74,7 @@
              >
            </select>
          </label>
-          <button type="submit">Submit</button>
+          <button type="submit">Apply</button>
        </form>
      </details>

--- a/web-app/src/routes/(authenticated)/website/[websiteId]/articles/[articleId]/+page.server.ts
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/articles/[articleId]/+page.server.ts
@@ -40,7 +40,6 @@ export const actions: Actions = {
    };

    if (coverFile) {
-      headers["X-Mimetype"] = coverFile.type;
      headers["X-Original-Filename"] = coverFile.name;
    }

@@ -82,7 +81,6 @@ export const actions: Actions = {
        "Content-Type": "application/octet-stream",
        Accept: "application/vnd.pgrst.object+json",
        "X-Website-Id": params.websiteId,
-        "X-Mimetype": file.type,
        "X-Original-Filename": file.name
      },
      body: await file.arrayBuffer(),
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/articles/[articleId]/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/articles/[articleId]/+page.svelte
@@ -119,7 +119,7 @@
        content={data.article.main_content ?? ""}
      />

-      <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+      <button type="submit" disabled={data.permissionLevel === 10}>Update article</button>
    </form>
  </section>
 </WebsiteEditor>
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/categories/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/categories/+page.svelte
@@ -44,7 +44,7 @@
          <input name="category-weight" type="number" min="0" required />
        </label>

-        <button type="submit" disabled={data.permissionLevel === 10}>Submit</button>
+        <button type="submit" disabled={data.permissionLevel === 10}>Create category</button>
      </form>
    </Modal>
  </section>
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/collaborators/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/collaborators/+page.svelte
@@ -51,7 +51,9 @@
          </select>
        </label>

-        <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}>Submit</button>
+        <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}
+          >Add collaborator</button
+        >
      </form>
    </Modal>
  </section>
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/legal-information/+page.server.ts
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/legal-information/+page.server.ts
@@ -68,7 +68,6 @@ export const actions: Actions = {
        "Content-Type": "application/octet-stream",
        Accept: "application/vnd.pgrst.object+json",
        "X-Website-Id": params.websiteId,
-        "X-Mimetype": file.type,
        "X-Original-Filename": file.name
      },
      body: await file.arrayBuffer(),
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/legal-information/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/legal-information/+page.svelte
@@ -61,7 +61,9 @@
        content={data.legalInformation?.main_content ?? ""}
      />

-      <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}>Submit</button>
+      <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}
+        >Update legal information</button
+      >
    </form>

    {#if data.legalInformation?.main_content}
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/logs/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/logs/+page.svelte
@@ -19,13 +19,13 @@

  if (data.website.content_type === "Blog") {
    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const { user, change_log, media, docs_category, ...restTables } = tables;
+    const { user, change_log, docs_category, ...restTables } = tables;
    resources = restTables;
  }

  if (data.website.content_type === "Docs") {
    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const { user, change_log, media, ...restTables } = tables;
+    const { user, change_log, ...restTables } = tables;
    resources = restTables;
  }

@@ -96,7 +96,7 @@
          </select>
        </label>
        <input type="hidden" name="page" value={1} />
-        <button type="submit">Submit</button>
+        <button type="submit">Apply</button>
      </form>
    </details>
    <div class="scroll-container">
--- a/web-app/src/routes/(authenticated)/website/[websiteId]/publish/+page.svelte
+++ b/web-app/src/routes/(authenticated)/website/[websiteId]/publish/+page.svelte
@@ -36,7 +36,9 @@
      be published on the Internet.
    </p>
    <form method="POST" action="?/publishWebsite" use:enhance={enhanceForm()}>
-      <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}>Publish</button>
+      <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}
+        >Publish website</button
+      >
    </form>
  </section>

@@ -73,7 +75,9 @@
            required
          />
        </label>
-        <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}>Submit</button>
+        <button type="submit" disabled={[10, 20].includes(data.permissionLevel)}
+          >Update domain prefix</button
+        >
      </form>
      {#if data.websiteOverview.domain_prefix?.prefix}
        <Modal id="delete-domain-prefix" text="Delete">